Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port : customizable login page #913

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Port : customizable login page #913

merged 2 commits into from
Sep 18, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Sep 18, 2024 •
edited
Loading

Description

Currently, the login page does not allow any customization.
Add an API endpoint, open to anyone, which returns custom welcome message given by admins.
Adds 2 ConfigProperties to store the message and if it should be shown.

Addressed Issue

Backport change DependencyTrack/hyades#1358
Frontend PR : DependencyTrack/hyades-frontend#133

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal @Gepardgame
feat: customizable login page
a7cfd76 
Co-Authored-By: Thomas Schauer-Köckeis <[email protected]>
@sahibamittal sahibamittal added enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base labels Sep 18, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Sep 18, 2024
@codacy-production Codacy Production
Copy link

codacy-production bot commented Sep 18, 2024 •
edited
Loading

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
✅ +0.02% (target: -1.00%) ✅ 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (9969486) 21312 17530 82.25%
Head commit (2f87416) 21335 (+23) 17553 (+23) 82.27% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#913) 25 25 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal mentioned this pull request Sep 18, 2024
Open
2 tasks
@nscuro nscuro merged commit 8a83c7f into main Sep 18, 2024
9 checks passed
@nscuro nscuro deleted the port-customizable-login-page branch September 18, 2024 14:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request v4-port PRs that were ported from the Dependency-Track v4.x code base
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sahibamittal @nscuro